Replace Parameter with Method Call

 

before

public class ReplaceParameterWithMethodCall_before {
	static public int quantity;
	static public int itemPrice;
	
	static public double getPrice() {
		int basePrice = quantity * itemPrice;
		int discountLevel;

		if (quantity > 100)
			discountLevel = 2;
		else
			discountLevel = 1;

		double finalPrice = discountedPrice(basePrice, discountLevel);

		return finalPrice;
	}

	static private double discountedPrice(int basePrice, int discountLevel) {
		if (discountLevel == 2)
			return basePrice * 0.1;
		else
			return basePrice * 0.05;
	}

	public static void main(String[] args) {
		quantity = 10;
		itemPrice = 2500;
		
		System.out.println("price : " + getPrice());

	}

}

 

after

public class ReplaceParameterWithMethodCall_before {
	static public int quantity;
	static public int itemPrice;
	
	static public double getPrice() {
		int basePrice = quantity * itemPrice;
		double finalPrice = discountedPrice(basePrice);
		return finalPrice;
	}

	static private double discountedPrice(int basePrice) {
		if (quantity > 100) return basePrice * 0.1;
		return basePrice * 0.05;  
	}

	public static void main(String[] args) {
		quantity = 10;
		itemPrice = 2500;
		
		System.out.println("price : " + getPrice());

	}

}